Skip to content

fix a few links#214

Merged
nikomatsakis merged 1 commit intorust-lang:mainfrom
lqd:linkify
Jan 13, 2025
Merged

fix a few links#214
nikomatsakis merged 1 commit intorust-lang:mainfrom
lqd:linkify

Conversation

@lqd
Copy link
Copy Markdown
Member

@lqd lqd commented Jan 10, 2025

The post-processor didn't linkify the RFC link from last time, so here is the PR I promised.

There was also a couple other links to fix in the RFL page.

Rendered

Comment thread src/2025h1/README.md Outdated
Copy link
Copy Markdown
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we figure out the linkifer bug. Or maybe those were disabled because the impl was so crappy, I remember @joshtriplett complaining about it.

Comment thread src/2025h1/README.md Outdated
* convene Rust maintainers to celebrate Rust's tenth birthday at [RustWeek 2025](https://2025.rustweek.org) (co-organized with [RustNL](https://2025.rustweek.org/about/);
* author a first draft for a [Rust vision doc](./rust-vision-doc.md) and gather feedback.

[RFC 3716]: https://github.com/rust-lang/rfcs/pull/3716
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. There is a linkifier declared:

[preprocessor.goals.linkifiers]
"RFC #([0-9]+)" = "https://github.com/rust-lang/rfcs/pull/$1"
"([a-zA-Z0-9-]+)/([a-zA-Z0-9-]+)#([0-9]+)" = "https://github.com/$1/$2/issues/$3"
"#([0-9]+)" = "https://github.com/rust-lang/rust/issues/$1"

I don't get why it's not working...?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#204 was the bug I was thinking of

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that only parse RFC #3716, not RFC 3716?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it should be RFC #?([0-9]+) if we want to allow both.

Copy link
Copy Markdown
Member Author

@lqd lqd Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't that only parse RFC #3716, not RFC 3716?

it was RFC #3716 in the original text, which causes even more confusion as to why it didn't work

@lqd
Copy link
Copy Markdown
Member Author

lqd commented Jan 13, 2025

I'd rather we figure out the linkifer bug. Or maybe those were disabled because the impl was so crappy,

Sure, I will try to find out.

@lqd
Copy link
Copy Markdown
Member Author

lqd commented Jan 13, 2025

The linkifier is not disabled locally and seems to work, but these links were using the incorrect micro-syntax: the linkifier doesn't trigger on RFC #123 but on [RFC #123].

I've updated the PR to restore and fix the original text.

@nikomatsakis
Copy link
Copy Markdown
Contributor

Thanks @lqd !

@nikomatsakis nikomatsakis merged commit 6255bff into rust-lang:main Jan 13, 2025
nikomatsakis added a commit to nikomatsakis/rust-project-goals-ndm that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants