-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the playground UI inside docker #191
Open
aidanhs
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
aidanhs:aphs-dockerise-play-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
FROM ubuntu:16.04 | ||
|
||
ENV USER=root | ||
ADD https://download.docker.com/linux/static/stable/x86_64/docker-17.03.0-ce.tgz / | ||
RUN cd /usr/bin/ && tar --strip-components=1 -xzf /docker-17.03.0-ce.tgz docker/docker | ||
WORKDIR /ui | ||
COPY ./target/x86_64-unknown-linux-musl/release/ui /ui/ | ||
COPY frontend/build /frontend | ||
ENV TMPDIR=/mnt/playground \ | ||
RUST_LOG=info \ | ||
PLAYGROUND_UI_ADDRESS=0.0.0.0 \ | ||
PLAYGROUND_UI_PORT=80 \ | ||
PLAYGROUND_UI_ROOT=/frontend | ||
ENTRYPOINT [] | ||
# Allow ctrl+C to work by wrapping the playground in bash | ||
# (it will also perform process reaping). The odd construction | ||
# is because if bash recognises a simple command it'll just | ||
# exec it directly, so add a useless additional command. | ||
CMD ["bash", "-c", "/ui/ui || false"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
#!/bin/bash | ||
|
||
set -euv -o pipefail | ||
|
||
perform_push="${PERFORM_PUSH-false}" | ||
|
||
repository=shepmaster | ||
|
||
# Build outside the image so nodejs isn't installed on the main image | ||
cd frontend | ||
docker pull node | ||
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash node -c ' | ||
yarn && | ||
NODE_ENV=production yarn run build | ||
' | ||
cd .. | ||
|
||
# Also don't put a rust compiler in the main playground image | ||
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash shepmaster/rust-nightly -c ' | ||
rustup target add x86_64-unknown-linux-musl && | ||
cargo build --target=x86_64-unknown-linux-musl --release | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With my proposed change to reuse the S3-uploaded artifacts, this file might not make sense as |
||
' | ||
|
||
image_name="playground" | ||
full_name="${repository}/${image_name}" | ||
docker pull "${full_name}" || true # not on docker hub...yet | ||
docker build -t "${full_name}" \ | ||
--cache-from "${full_name}" \ | ||
. | ||
docker tag "${full_name}" "${image_name}" | ||
if [[ "${perform_push}" == 'true' ]]; then | ||
docker push "${full_name}" | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't wait for multi stage builds to land on a version of Docker we have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I've wanted that for about three years now. Didn't realise they finally decided to implement it!