Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the playground UI inside docker #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis/build-containers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ then
docker login -u="${DOCKER_USERNAME}" -p="${DOCKER_PASSWORD}"
export PERFORM_PUSH="true"
# Which images to build are set via .travis.yml
cd compiler && ./build.sh
cd compiler && ./build.sh && cd ..
cd ui && ./build.sh && cd ..
fi
33 changes: 9 additions & 24 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ cd rust-playground
```
cd compiler/
./build.sh
cd ../
cd ..
```

#### Set a crontab to rebuild the containers
Expand All @@ -151,36 +151,20 @@ crontab -e
0 * * * * docker images -q --filter "dangling=true" | xargs docker rmi
```

#### Build the UI backend
#### Build the UI frontend and backend
```
cd ui
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash rust-nightly
rustup target add x86_64-unknown-linux-musl
cargo build --target=x86_64-unknown-linux-musl --release
# exit docker
./build.sh
cd ..
```

#### Build the UI frontend
```
cd ui/frontend
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash node
yarn
NODE_ENV=production yarn run build
# exit docker
cd ../..
```

#### Run the server
```
cd ui
sudo \
TMPDIR=/mnt/playground \
RUST_LOG=info \
PLAYGROUND_UI_ADDRESS=0.0.0.0 \
PLAYGROUND_UI_PORT=80 \
PLAYGROUND_UI_ROOT=$PWD/frontend/build \
./target/x86_64-unknown-linux-musl/release/ui
docker run -it --rm \
--volume /var/run/docker.sock:/var/run/docker.sock \
--volume /mnt/playground:/mnt/playground \
--publish 80:80 \
playground
```

## Development
Expand Down Expand Up @@ -208,6 +192,7 @@ cargo run
```
cd compiler
./build.sh
cd ..
```

## License
Expand Down
19 changes: 19 additions & 0 deletions ui/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
FROM ubuntu:16.04

ENV USER=root
ADD https://download.docker.com/linux/static/stable/x86_64/docker-17.03.0-ce.tgz /
RUN cd /usr/bin/ && tar --strip-components=1 -xzf /docker-17.03.0-ce.tgz docker/docker
WORKDIR /ui
COPY ./target/x86_64-unknown-linux-musl/release/ui /ui/
COPY frontend/build /frontend
ENV TMPDIR=/mnt/playground \
RUST_LOG=info \
PLAYGROUND_UI_ADDRESS=0.0.0.0 \
PLAYGROUND_UI_PORT=80 \
PLAYGROUND_UI_ROOT=/frontend
ENTRYPOINT []
# Allow ctrl+C to work by wrapping the playground in bash
# (it will also perform process reaping). The odd construction
# is because if bash recognises a simple command it'll just
# exec it directly, so add a useless additional command.
CMD ["bash", "-c", "/ui/ui || false"]
33 changes: 33 additions & 0 deletions ui/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
#!/bin/bash

set -euv -o pipefail

perform_push="${PERFORM_PUSH-false}"

repository=shepmaster

# Build outside the image so nodejs isn't installed on the main image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wait for multi stage builds to land on a version of Docker we have!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I've wanted that for about three years now. Didn't realise they finally decided to implement it!

cd frontend
docker pull node
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash node -c '
yarn &&
NODE_ENV=production yarn run build
'
cd ..

# Also don't put a rust compiler in the main playground image
docker run -it --rm -v $PWD:/ui --workdir /ui --entrypoint /bin/bash shepmaster/rust-nightly -c '
rustup target add x86_64-unknown-linux-musl &&
cargo build --target=x86_64-unknown-linux-musl --release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my proposed change to reuse the S3-uploaded artifacts, this file might not make sense as ui/build.sh anymore. It could just be moved to the .travis/ directory.

'

image_name="playground"
full_name="${repository}/${image_name}"
docker pull "${full_name}" || true # not on docker hub...yet
docker build -t "${full_name}" \
--cache-from "${full_name}" \
.
docker tag "${full_name}" "${image_name}"
if [[ "${perform_push}" == 'true' ]]; then
docker push "${full_name}"
fi