Clarify that beta builds can be picked up by version#1023
Clarify that beta builds can be picked up by version#1023apiraino wants to merge 2 commits intorust-lang:masterfrom
Conversation
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
LGTM. |
Ok, thanks! I thought to leave that as second option but I'm fine as well with removing it. I'll leave to the reviewer to figure out :) |
|
I didn't know this was possible, and I can't find an example where it has been used. Do you have any citations? |
This wasn't possible for a long time. Only since 1.75-beta does the release process generate the necessary channel files1 and only in rustup 1.28.0 has the support been added to rustup to use those channel files2. I don't have any citations of this having been used. Given that most crater runs are master compared to PR or beta crater runs following the current instructions that is somewhat expected. I did intend to try it myself, but forgot to do that, sorry. I did look at the crater and rustwide source and if the toolchain isn't a sha hash it should end up at https://docs.rs/rustwide/latest/rustwide/toolchain/struct.Toolchain.html#method.dist3 which claims to support all rustup toolchain names and
https://docs.rs/rustwide/latest/src/rustwide/toolchain.rs.html#43-58 As long as the rustup version used by crater/rsutwide is at least 1.28.0 this should work. Crater is currently on rustwide version 0.19.34, and rustwide should update rustup automatically (except in rustwide 0.19.15) Edit: in the meantime I have tested using the crater cli and using 1.95.0-beta.3 worked. Footnotes |
|
I'm running crater for 1.95 in rust-lang/rust#153551 -- when that inevitably needs retries, I'll try using the new suggestion here and see how it goes. |
7850191 to
b486663
Compare
Co-authored-by: Bennet Bleßmann <3877590+Skgland@users.noreply.github.com>
Closes #992
cc: @Skgland does it read better now?
Thanks
Rendered