Add a new lint to check for use of std::env::set_var in tests #15986
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Adds a new lint to check for use of
std::env::set_varin unit tests.In our experience in https://github.com/block/goose, setting environment variables in tests has been the largest source of test flakiness. Test authors often think that if they properly clean up the mutated variable, all is well. But because tests run concurrently, there is really no way to isolate this effect other than marking them using e.g. https://crates.io/crates/serial_test.
changelog: [
set_env_in_tests]: checks for use ofstd::env::set_varin unit tests