Skip to content

Fix branches_sharing_code suggests misleadingly when in assignment #15076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 18, 2025

The lint will note the end suggestion probably needs some adjustments to use the expression result correctly when the expr's is not unit. So I extend this note to also appear when the expr is in an assignment.

changelog: [branches_sharing_code] fix misleading suggestions when in assignment

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 18, 2025
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really fix the issue, but it helps. Thank you.

@Jarcho Jarcho added this pull request to the merge queue Jun 20, 2025
Merged via the queue into rust-lang:master with commit 6064822 Jun 20, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants