Skip to content

Fix never_loop forget to remove break in suggestion #15064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix never_loop forget to remove break in suggestion #15064

wants to merge 1 commit into from

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 16, 2025 •
edited by rustbot
Loading

Closes #15007

Removes the break stmt and the dead code after it when appropriate.

changelog: [never_loop] add to remove break in suggestion

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 16, 2025
@profetia profetia force-pushed the issue15007 branch 2 times, most recently from d2ee798 to 4f18d7f Compare June 17, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

never_loop should also remove break labels that were inside the loop
3 participants
@profetia @rustbot @Alexendoo