Do not lint macro generated codes #14976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
`disallowed_names` was used to lint code generated by macros. This behavior can confuse programmers who did not write the macro themselves. This change suppresses lints for code originating from macros, including external ones. changelog: [`disallowed_names`] do not lint macro generated codes
donkomura
force-pushed
the
disallowed_names_do_not_lint_proc_macros
branch
from
bb8c0d5 to
c9a97e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14958
disallowed_nameswas used to lint code generated by macros. This behavior can confuse programmers who did not write the macro themselves. This change suppresses lints for code originating from macros, including external ones.changelog: [
disallowed_names] do not lint macro generated codes