Skip to content

Do not count deprecated lints in lint total #14948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

samueltardieu
Copy link
Contributor

In order to be consistent with our documentation, deprecated lints should not be counted when displaying the total number of lints on the web site.

For example, as of 2025-06-01, there are 784 non-deprecated lints which are referred to as "over 750 lints" in the documentation, but the web site displays "Total number: 799". When one new lint will be added, there will be a discrepancy ("over 750 lints" vs. "Total number: 800") if this is not fixed.

changelog: none

r? @llogiq

In order to be consistent with our documentation, deprecated lints
should not be counted when displaying the total number of lints on the
[web site](https://rust-lang.github.io/rust-clippy/master/index.html).

For example, as of 2025-06-01, there are 784 non-deprecated lints which
are referred to as "over 750 lints" in the documentation, but the web site
displays "Total number: 799". When one new lint will be added, there
will be a discrepancy ("over 750 lints" vs. "Total number: 800") if this
is not fixed.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2025
@samueltardieu
Copy link
Contributor Author

@llogiq I've assigned it to you as you are probably merging a lint today, which would make the discrepancy between the documentation and the web site visible (785 lints ⇒ "over 750 lints", with "Total number: 800" displayed on the web site).

@llogiq llogiq added this pull request to the merge queue Jun 1, 2025
@llogiq
Copy link
Contributor

llogiq commented Jun 1, 2025

Good catch. I remember we talked about this during the all-hands, but totally forgot to do something about it.

Merged via the queue into rust-lang:master with commit 466e0fb Jun 1, 2025
8 checks passed
@samueltardieu samueltardieu deleted the fix-web-lint-count branch June 2, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants