Skip to content

Emit lint about redundant closure on the closure node itself #14791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented May 12, 2025

Fixes #14789

changelog: [redundant_closure], [redundant_closure_for_method_calls]: allow lint to be allowed or expected on the closure expression itself

@rustbot
Copy link
Collaborator

rustbot commented May 12, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 12, 2025
@samueltardieu
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned flip1995 and unassigned dswij May 26, 2025
@samueltardieu
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned llogiq and unassigned flip1995 Jun 18, 2025
@samueltardieu
Copy link
Contributor Author

Note: the change are trivial, and are best reviewed with "hide whitespace changes" option on, as using span_lint_hir_and_then() instead of span_lint_and_sugg() as added an indentation level but the content hasn't changed.

@y21
Copy link
Member

y21 commented Jun 21, 2025

r? @y21

@rustbot rustbot assigned y21 and unassigned llogiq Jun 21, 2025
@y21 y21 added this pull request to the merge queue Jun 21, 2025
Merged via the queue into rust-lang:master with commit 6330f91 Jun 21, 2025
11 checks passed
@samueltardieu samueltardieu deleted the issue-14789 branch June 21, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression of #[allow(clippy::redundant_closure)] in Rust 1.82
6 participants