Gate collapsible_if let_chains lints on edition 2024 and MSRV #14723
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
the
S-waiting-on-review
|
I'll take it, I'm back online on Monday. |
|
Oops, forgot about that. Thanks! |
clippy_lints_internal/Cargo.toml
Outdated
| edition = "2021" | ||
| edition = "2024" |
There was a problem hiding this comment.
Is it really part of this PR? Maybe at least a separate commit would be clearer.
There was a problem hiding this comment.
It was leftover from another change
| fn eligible_condition(&self, cx: &LateContext<'_>, cond: &Expr<'_>) -> bool { | ||
| !matches!(cond.kind, ExprKind::Let(..)) | ||
| || (cx.tcx.sess.edition().at_least_rust_2024() && self.msrv.meets(cx, msrvs::LET_CHAINS)) |
There was a problem hiding this comment.
Any reason to prefer passing an extra argument every time (cx) and doing an edition comparison, while the edition being ≥2024 could instead be checked once from tcx at CollapsibleIf::new() time? The performance hit should be unnoticeable, but I wonder why you made this choice.
There was a problem hiding this comment.
cx is required for the MSRV check so doing so doesn't remove the extra arg
It could've been done once in new, it's not really something I actively considered. Perf wise it's an extra pointer dereference or two, doesn't seem worth splitting up the condition
Alexendoo
force-pushed
the
collapsible-if-chain-msrv
branch
from
6e7f20c to
8c93668
Compare
The MSRV being for crates targeting 1.85-1.87 on edition 2024
This enables the lint for regular nightly users without the feature gate enabled
r? @samueltardieu
Fixes #14678
changelog: none