Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es translation to 3100 #1911

Merged
merged 4 commits into from
Feb 4, 2025
Merged

es translation to 3100 #1911

merged 4 commits into from
Feb 4, 2025

Conversation

miguelraz
Copy link
Contributor

@miguelraz miguelraz commented Feb 3, 2025

Feel free to merge, I'll work on these in ~500 or 1k line increments. and PR them as they come along.

@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

r? @marioidival

rustbot has assigned @marioidival.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@miguelraz miguelraz changed the title es translation to 2600 es translation to 3100 Feb 3, 2025
@marioidival marioidival merged commit a349a04 into rust-lang:master Feb 4, 2025
1 check passed
@miguelraz
Copy link
Contributor Author

@marioidival Sorry, the recent deploy is the showing spanish as an option on the website.

What can I help with?

@marioidival
Copy link
Member

@miguelraz are you sure?
image
At least for me is not showing anything.

@miguelraz
Copy link
Contributor Author

Ugh I missed the not.

Yes, it's missing.

Can I help or poke someone that can?

@marioidival
Copy link
Member

Ah, I see! Deployment to master only happens when the Rust team generates a new release. So, in a way, we don't have the version in the main RBE, but in the nightly version it should probably already be available.

is not available

@dalance did you have any idea about it? It was the guy that introduce the translation here

@dalance
Copy link
Contributor

dalance commented Feb 5, 2025

I checked the current status.
7437669 is merged into rust-lang/rust just today. So es entry in language picker will apear at the next nightly build tomorrow in the following URL.

https://doc.rust-lang.org/nightly/rust-by-example/

Additionally adding es entry to the following line in rust-lang/rust is necessary.
This change enables to build the es contents in the build step of Rust.

https://github.com/rust-lang/rust/blob/bef3c3b01f690de16738b1c9f36470fbfc6ac623/src/bootstrap/src/core/build_steps/doc.rs#L74

After merging the change, the next nightly build will work fine.
At the next stable release (1.85.0), the beta becomes ready.

https://doc.rust-lang.org/beta/rust-by-example/

And finally at the next next stable release (1.86.0), the stable becomes ready.

https://doc.rust-lang.org/rust-by-example/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants