Refactor item_name method to use ItemInfo struct #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
force-pushed
the
pass-item-info-to-item-name
branch
from
6dbc697 to
27b6d79
Compare
emilio
requested changes
Feb 17, 2025
| crate::callbacks::ItemKind::Function | ||
| } | ||
| _ => crate::callbacks::ItemKind::Var, | ||
| }, |
There was a problem hiding this comment.
Is this correct? There are no tests for this but reporting everything that isn't a function a Var seems totally wrong.
There was a problem hiding this comment.
Good catch, it isn't really correct. It looks like the ir ItemKind type has 4 variants, while the callback ItemKind type has only 2. Modules and Types are the variants missing, I'll add those to the callback enum so that they can be correctly handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the name as a
&stris passed, which has the limitation that you cannot differentiate between functions and other types. An example use case of this is if you wanted to rename Structs/Unions/Enums to use PascalCase but rename functions to use snake_case, to better follow Rust's conventions.Fixes #2736