fix: load rust-analyzer.toml for virtual workspaces#21704
Open
Madoshakalaka wants to merge 1 commit intorust-lang:masterfrom
Open
fix: load rust-analyzer.toml for virtual workspaces#21704Madoshakalaka wants to merge 1 commit intorust-lang:masterfrom
Madoshakalaka wants to merge 1 commit intorust-lang:masterfrom
Conversation
Virtual workspaces (with no root package) had no local source root for the workspace root directory, causing rust-analyzer.toml placed there to fall into a library source root and be silently ignored.
rustbot
added
the
S-waiting-on-review
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the most common case of broken
rust-analyzer.tomlloading: virtual workspacesFor virtual workspaces,
ProjectWorkspace::to_roots()only createsPackageRoots for member crate packages. The workspace root directory itself gets none.Any
rust-analyzer.tomlplaced at the workspace root then falls into the default (library) source root and is silently ignored byprocess_changes().The fix ensures every workspace root is included as a local source root in
ProjectFolders::new(), even when no package lives there.Relates to #13529, fixes #18943.