fix: Allow leading | in more pattern positions#13096
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 23, 2022
jonas-schievink:parse-more-or-pats
Merged
fix: Allow leading | in more pattern positions#13096bors merged 1 commit intorust-lang:masterfrom jonas-schievink:parse-more-or-pats
| in more pattern positions#13096bors merged 1 commit intorust-lang:masterfrom
jonas-schievink:parse-more-or-pats
Conversation
Contributor
Author
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12894, fixes #13094
Oddly, the leading
|token does not end up inside theOR_PATnode, sincepattern_top_rconsumes it first. This is a preexisting issue in match arms though, so I didn't fix it here.