Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spec Identifier Syntax to expressions.md and subchapters #1591

Merged
merged 17 commits into from
Jan 31, 2025
Merged

Add Spec Identifier Syntax to expressions.md and subchapters #1591

merged 17 commits into from
Jan 31, 2025
+623 −7

Conversation

chorman0773
Copy link
Contributor

This adds identifier syntax to expressions.md and all subchapters.

@chorman0773 chorman0773 added S-waiting-on-review Status: The marked PR is awaiting review from a maintainer T-spec Team: spec labels Aug 27, 2024
@chorman0773 chorman0773 self-assigned this Aug 27, 2024
@chorman0773 chorman0773 mentioned this pull request Aug 27, 2024
Open
90 tasks
traviscross
traviscross reviewed Aug 27, 2024
View reviewed changes
src/expressions.md Outdated Show resolved Hide resolved
traviscross
traviscross previously requested changes Oct 18, 2024
View reviewed changes
src/expressions.md Outdated Show resolved Hide resolved
src/expressions/grouped-expr.md Outdated Show resolved Hide resolved
src/expressions/method-call-expr.md Outdated Show resolved Hide resolved
src/expressions/method-call-expr.md Outdated Show resolved Hide resolved
src/expressions/method-call-expr.md Outdated Show resolved Hide resolved
src/expressions/method-call-expr.md Outdated Show resolved Hide resolved
@rustbot

This comment has been minimized.

Sign in to view
@chorman0773
Copy link
Contributor Author

@rustbot ready

@rustbot

This comment has been minimized.

Sign in to view
chorman0773 and others added 17 commits January 30, 2025 10:49
@chorman0773 @ehuss
Add paragraph identifiers to expressions.md
9134fe5
@chorman0773 @ehuss
Add identifier syntax to array-expr through block-expr
9446598
@chorman0773 @ehuss
Add identifier syntax to call-expr
60b1720
@chorman0773 @ehuss
Add identifier syntax to closure-expr, field-expr, and grouped-expr
aae16d5
@chorman0773 @ehuss
Add identifier syntax to if-expr and literal-expr
c4ebffe
@chorman0773 @ehuss
Add identifier syntax to loop-expr and match-expr
2e00df4
@chorman0773 @ehuss
Add identifier syntax to method-call-expr and operator-expr
735991b
@chorman0773 @ehuss
Add identifier syntax to path-expr, range-expr, return-expr, struct-e…
54ed666 
…xpr, tuple-expr, and underscore-expr
@chorman0773 @ehuss
Remove double-spaces and trailing whitespace
a7b725b
@chorman0773 @ehuss
Refer to Some(x) in expr.try.result-some
53c23d7
@chorman0773 @ehuss
Remove extraneous whitespace from literal-expr
b25591a
@chorman0773 @ehuss
Fix spelling from behaviour to behavior
1f38602
@chorman0773 @ehuss
Fix mdbook-spec identifiers to be unique
eed74c2
@chorman0773 @traviscross @ehuss
Apply suggestions from code review
fbe355b 
Co-authored-by: Travis Cross <[email protected]>
@ehuss
Adjust rules next to headers
853ccb4
@ehuss
Add some missing rules
efe16bf
@ehuss
Adjust some rule names for clarity
3e57a06 
This adjusts some rule names to be more explicit about what they are
for.
@ehuss ehuss force-pushed the spec-add-identifiers-exprs branch from da42d7c to 3e57a06 Compare January 31, 2025 03:40
ehuss
ehuss approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I really appreciate all the work you put into this.

@ehuss ehuss enabled auto-merge January 31, 2025 03:42
@ehuss ehuss added this pull request to the merge queue Jan 31, 2025
Merged via the queue into rust-lang:master with commit 4249fb4 Jan 31, 2025
5 checks passed
@rustbot rustbot mentioned this pull request Feb 3, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#136498 - rustbot:docs-update, r=ehuss
81aa190 
Update books

## rust-lang/book

2 commits in fa312a343fbff01bc6cef393e326817f70719813..e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45
2025-02-03 15:02:07 UTC to 2025-02-01 17:33:39 UTC

- Add missing word in ch17-04-streams.md (rust-lang/book#4218)
- Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216)

## rust-lang/edition-guide

2 commits in 4ed5a1a4a2a7ecc2e529a5baaef04f7bc7917eda..f56aecc3b036dff16404b525a83b00f911b9bbea
2025-02-03 17:14:16 UTC to 2025-01-31 17:44:00 UTC

- Rustc{En,De}codable has been removed (rust-lang/edition-guide#353)
- Remove rustfmt-overflow-delimited-expr (rust-lang/edition-guide#357)

## rust-lang/nomicon

3 commits in bc2298865544695c63454fc1f9f98a3dc22e9948..336f75835a6c0514852cc65aba9a698b699b13c8
2025-02-02 10:06:30 UTC to 2025-02-02 08:35:20 UTC

- Improve grammar in exotic-sizes (rust-lang/nomicon#452)
- other-reprs: Add details for n!=1 repr(packed) (rust-lang/nomicon#460)
- Use `()` instead of `[u8; 0]` in opaque type (rust-lang/nomicon#456)

## rust-lang/reference

3 commits in 93b921c7d3213d38d920f7f905a3bec093d2217d..4249fb411dd27f945e2881eb0378044b94cee06f
2025-01-31 03:43:07 UTC to 2025-01-29 04:17:34 UTC

- Add Spec Identifier Syntax to expressions.md and subchapters (rust-lang/reference#1591)
- Exclude the test summary from the search index (rust-lang/reference#1723)
- Spec inline assembly tests (rust-lang/reference#1648)

## rust-lang/rust-by-example

1 commits in 054259ed1bf01cdee4309ee764c7e103f6df3de5..743766929f1e53e72fab74394ae259bbfb4a7619
2025-02-02 19:53:31 UTC to 2025-02-02 19:53:31 UTC

- Spanish translation to 1:2100 (rust-lang/rust-by-example#1910)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#136498 - rustbot:docs-update, r=ehuss
1869633 
Update books

## rust-lang/book

2 commits in fa312a343fbff01bc6cef393e326817f70719813..e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45
2025-02-03 15:02:07 UTC to 2025-02-01 17:33:39 UTC

- Add missing word in ch17-04-streams.md (rust-lang/book#4218)
- Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216)

## rust-lang/edition-guide

2 commits in 4ed5a1a4a2a7ecc2e529a5baaef04f7bc7917eda..f56aecc3b036dff16404b525a83b00f911b9bbea
2025-02-03 17:14:16 UTC to 2025-01-31 17:44:00 UTC

- Rustc{En,De}codable has been removed (rust-lang/edition-guide#353)
- Remove rustfmt-overflow-delimited-expr (rust-lang/edition-guide#357)

## rust-lang/nomicon

3 commits in bc2298865544695c63454fc1f9f98a3dc22e9948..336f75835a6c0514852cc65aba9a698b699b13c8
2025-02-02 10:06:30 UTC to 2025-02-02 08:35:20 UTC

- Improve grammar in exotic-sizes (rust-lang/nomicon#452)
- other-reprs: Add details for n!=1 repr(packed) (rust-lang/nomicon#460)
- Use `()` instead of `[u8; 0]` in opaque type (rust-lang/nomicon#456)

## rust-lang/reference

3 commits in 93b921c7d3213d38d920f7f905a3bec093d2217d..4249fb411dd27f945e2881eb0378044b94cee06f
2025-01-31 03:43:07 UTC to 2025-01-29 04:17:34 UTC

- Add Spec Identifier Syntax to expressions.md and subchapters (rust-lang/reference#1591)
- Exclude the test summary from the search index (rust-lang/reference#1723)
- Spec inline assembly tests (rust-lang/reference#1648)

## rust-lang/rust-by-example

1 commits in 054259ed1bf01cdee4309ee764c7e103f6df3de5..743766929f1e53e72fab74394ae259bbfb4a7619
2025-02-02 19:53:31 UTC to 2025-02-02 19:53:31 UTC

- Spanish translation to 1:2100 (rust-lang/rust-by-example#1910)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
@rust-timer
Unrolled build for rust-lang#136498
fb4252f 
Rollup merge of rust-lang#136498 - rustbot:docs-update, r=ehuss

Update books

## rust-lang/book

2 commits in fa312a343fbff01bc6cef393e326817f70719813..e2fa4316c5a7c0d2499c5d6b799adcfad6ef7a45
2025-02-03 15:02:07 UTC to 2025-02-01 17:33:39 UTC

- Add missing word in ch17-04-streams.md (rust-lang/book#4218)
- Fix typo in ch5.3 and in CONTRIBUTING.md (rust-lang/book#4216)

## rust-lang/edition-guide

2 commits in 4ed5a1a4a2a7ecc2e529a5baaef04f7bc7917eda..f56aecc3b036dff16404b525a83b00f911b9bbea
2025-02-03 17:14:16 UTC to 2025-01-31 17:44:00 UTC

- Rustc{En,De}codable has been removed (rust-lang/edition-guide#353)
- Remove rustfmt-overflow-delimited-expr (rust-lang/edition-guide#357)

## rust-lang/nomicon

3 commits in bc2298865544695c63454fc1f9f98a3dc22e9948..336f75835a6c0514852cc65aba9a698b699b13c8
2025-02-02 10:06:30 UTC to 2025-02-02 08:35:20 UTC

- Improve grammar in exotic-sizes (rust-lang/nomicon#452)
- other-reprs: Add details for n!=1 repr(packed) (rust-lang/nomicon#460)
- Use `()` instead of `[u8; 0]` in opaque type (rust-lang/nomicon#456)

## rust-lang/reference

3 commits in 93b921c7d3213d38d920f7f905a3bec093d2217d..4249fb411dd27f945e2881eb0378044b94cee06f
2025-01-31 03:43:07 UTC to 2025-01-29 04:17:34 UTC

- Add Spec Identifier Syntax to expressions.md and subchapters (rust-lang/reference#1591)
- Exclude the test summary from the search index (rust-lang/reference#1723)
- Spec inline assembly tests (rust-lang/reference#1648)

## rust-lang/rust-by-example

1 commits in 054259ed1bf01cdee4309ee764c7e103f6df3de5..743766929f1e53e72fab74394ae259bbfb4a7619
2025-02-02 19:53:31 UTC to 2025-02-02 19:53:31 UTC

- Spanish translation to 1:2100 (rust-lang/rust-by-example#1910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

@traviscross traviscross traviscross left review comments

Assignees

@chorman0773 chorman0773

Labels
S-waiting-on-review Status: The marked PR is awaiting review from a maintainer T-spec Team: spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chorman0773 @rustbot @ehuss @traviscross