Skip to content

Windows: Implement MoveFileExW shim#4823

Merged
RalfJung merged 1 commit intorust-lang:masterfrom
CraftSpider:windows-rename
Mar 27, 2026
Merged

Windows: Implement MoveFileExW shim#4823
RalfJung merged 1 commit intorust-lang:masterfrom
CraftSpider:windows-rename

Conversation

@CraftSpider
Copy link
Copy Markdown
Contributor

@CraftSpider CraftSpider commented Jan 22, 2026

This allows rename to work. Doesn't support renaming to directory form yet, as that requires a form of SetFileInfo

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jan 22, 2026

Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two.
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jan 22, 2026
RalfJung
RalfJung reviewed Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@RalfJung RalfJung left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait! Looks good overall, but I have a minor question.

View changes since this review

Comment thread src/shims/windows/fs.rs Outdated
Comment thread src/shims/windows/fs.rs Outdated
@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Feb 21, 2026

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Feb 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 21, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Feb 21, 2026
@CraftSpider
Copy link
Copy Markdown
Contributor Author

CraftSpider commented Mar 20, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Mar 20, 2026
@RalfJung RalfJung added this pull request to the merge queue Mar 21, 2026
@RalfJung RalfJung removed this pull request from the merge queue due to a manual request Mar 21, 2026
@RalfJung
Copy link
Copy Markdown
Member

RalfJung commented Mar 21, 2026

This looks great, thanks! Please squash the commits. You can squash manually if there are multiple independent commits you want to preserve, or use ./miri squash (make sure to pick a suitable commit message). Then write @rustbot ready after you force-pushed the squashed PR.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Mar 21, 2026
@CraftSpider
Copy link
Copy Markdown
Contributor Author

CraftSpider commented Mar 27, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Mar 27, 2026
@RalfJung RalfJung added this pull request to the merge queue Mar 27, 2026
Merged via the queue into rust-lang:master with commit 3f739af Mar 27, 2026
13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CraftSpider @rustbot @RalfJung