Skip to content

Conversation

@semarie
Copy link
Contributor

@semarie semarie commented Jan 27, 2026

Description

The PR makes the CI to ignore tm_zone field in struct tm. The const has been recently added in OpenBSD (see sources).

The another way is to properly define struct tm in OpenBSD, and move the currently global definition to each unix platform. It might be preferable. Feel free to ask for this way 😃

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@JohnTitor
Copy link
Member

The another way is to properly define struct tm in OpenBSD, and move the currently global definition to each unix platform. It might be preferable. Feel free to ask for this way 😃

If it doesn't confuse downstream users, I'd prefer! I'm not sure but OpenBSD 7.8 doesn't have it yet?

@semarie
Copy link
Contributor Author

semarie commented Jan 28, 2026

the change (on OpenBSD side) is for upcoming OpenBSD-7.9

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JohnTitor JohnTitor enabled auto-merge January 28, 2026 10:11
@JohnTitor JohnTitor added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@JohnTitor JohnTitor added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@JohnTitor JohnTitor added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@tgross35 tgross35 added this pull request to the merge queue Jan 28, 2026
Merged via the queue into rust-lang:main with commit 7be4e60 Jan 28, 2026
50 of 51 checks passed
@semarie semarie deleted the semarie/tm-tmzone branch January 28, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants