Skip to content

Conversation

@Thomasdezeeuw
Copy link
Contributor

Description

Adds siginfo_t::si_status.

Sources

Definition of siginfo_t: https://github.com/openbsd/src/blob/7a3d6f69f0a9b1766a54f549b550113ea4d460f1/sys/sys/siginfo.h#L133-L174

Accessing si_status: https://github.com/openbsd/src/blob/7a3d6f69f0a9b1766a54f549b550113ea4d460f1/sys/sys/siginfo.h#L179

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

Some changes occurred in OpenBSD module

cc @semarie

@rustbot rustbot added O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jan 27, 2026
@Thomasdezeeuw
Copy link
Contributor Author

I wasn't able to test this locally. Is the CI alone sufficient to test this?

Thomasdezeeuw added a commit to Thomasdezeeuw/a10 that referenced this pull request Jan 27, 2026
This needs two changes to libc before it can be merged:
 * various constants for kqueue: rust-lang/libc#4945
 * siginfo_t::si_status: rust-lang/libc#4946
Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI doesn't look at the struct definition inside the function. so only manual inspection will properly doing it.

Copy link
Contributor Author

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the fields @semarie

Copy link
Contributor

@semarie semarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@JohnTitor JohnTitor force-pushed the openbsd-siginfo_t-si_status branch from 21e5e62 to 8523238 Compare January 28, 2026 10:11
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JohnTitor JohnTitor added this pull request to the merge queue Jan 28, 2026
Merged via the queue into rust-lang:main with commit 3749159 Jan 28, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants