-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add siginfo_t::si_status #4946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add siginfo_t::si_status #4946
Conversation
|
Some changes occurred in OpenBSD module cc @semarie |
|
I wasn't able to test this locally. Is the CI alone sufficient to test this? |
This needs two changes to libc before it can be merged: * various constants for kqueue: rust-lang/libc#4945 * siginfo_t::si_status: rust-lang/libc#4946
semarie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CI doesn't look at the struct definition inside the function. so only manual inspection will properly doing it.
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the fields @semarie
semarie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
21e5e62 to
8523238
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
JohnTitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Adds
siginfo_t::si_status.Sources
Definition of
siginfo_t: https://github.com/openbsd/src/blob/7a3d6f69f0a9b1766a54f549b550113ea4d460f1/sys/sys/siginfo.h#L133-L174Accessing
si_status: https://github.com/openbsd/src/blob/7a3d6f69f0a9b1766a54f549b550113ea4d460f1/sys/sys/siginfo.h#L179Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated