NetBSD if_msghdr fix for ilp32 hosts #4902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hosts:
This fixes the following errors from `cd libc-test; cargo test`:
bad `if_msghdr` size: rust: 148 != c 152
bad `if_msghdr` align: rust: 4 != c 8
and
size of `struct if_msghdr` is 152 in C and 148 in Rust
as verified natively on NetBSD/i386 10.0 with rust 1.92.0.
Ref. https://nxr.netbsd.org/xref/src/sys/net/if.h#790 for the
original C definition of `struct if_msghdr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the following errors from
cd libc-test; cargo test:as verified natively on NetBSD/i386 10.0 with rust 1.92.0.
Sources
struct if_msghdr.Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI