Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify FIXMEs in repo - 2 #4230

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Classify FIXMEs in repo - 2 #4230

merged 1 commit into from
Jan 10, 2025

Conversation

lvllvl
Copy link
Contributor

@lvllvl lvllvl commented Jan 6, 2025

Description

Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
    • Not applicable
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI
    • Not applicable

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2025

Some changes occurred in the Android module

cc @maurer

src/unix/mod.rs Outdated Show resolved Hide resolved
src/windows/mod.rs Outdated Show resolved Hide resolved
@tgross35
Copy link
Contributor

tgross35 commented Jan 6, 2025

Left a couple comments, please also the debug changes from #4229 (review). You can probably just find+replace those

@lvllvl
Copy link
Contributor Author

lvllvl commented Jan 9, 2025

Left a couple comments, please also the debug changes from #4229 (review). You can probably just find+replace those

Ok I think this one is good to go now as well. No rush, just wanted to lyk.

Please let me know if any other changes are needed.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@tgross35 tgross35 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into rust-lang:main with commit 55d8d83 Jan 10, 2025
45 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 10, 2025
@lvllvl lvllvl deleted the 4117-part-2 branch February 5, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants