[0.2] Define c_char at top-level and remove per-target c_char definitions #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgross35: no appropriate reviewer found, use |
|
As for 0.2, we also need to remove c_char from src/psp.rs, like https://github.com/rust-lang/libc/pull/4203/files#diff-0abdf4e9d0e64b993ee63247b3ed855cbf4c6e795b7982a371e9576b78f61c50. |
|
Thanks, added 50f82ad to address this. |
auto-merge was automatically disabled
December 19, 2024 09:11
Pull Request is not mergeable
auto-merge was automatically disabled
December 19, 2024 09:14
Pull Request is not mergeable
auto-merge was automatically disabled
December 19, 2024 09:14
Pull Request is not mergeable
auto-merge was automatically disabled
December 19, 2024 09:15
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge already, or at least notify me when you don't want to... |
(backport <rust-lang#4202>) (cherry picked from commit 0a02b94)
The exception was added after the PR with 0a02b94 ("Define c_char at top-level...") was posted. Remove this skip since the same commit makes it no longer relevant. (backport <rust-lang#4202>) (cherry picked from commit 2bb023e)
ef8c0f3 ("Define c_char at top-level...") removes the need for per-OS definitions of `c_char`. Remove the definition of `c_char` from PEP, which as not covered in the backport (as this module does not exist on `main`). Suggested-by: Taiki Endo <[email protected]>
tgross35
force-pushed
the
backport-c_char-top-level
branch
from
50f82ad to
37ac889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #4202