Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enable allocator-api2/nightly feature #606

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

NeuralModder
Copy link

@NeuralModder NeuralModder commented Jan 27, 2025

See #564 for rationale. Tentatively fixes said issue and #483, though the root cause is up to the allocator-api2 crate to fix.

Direct use of allocator-api2 in tests had to be replaced with the indirection used elsewhere in the crate.

See rust-lang#564 for rationale. Tentatively fixes said issue and rust-lang#483, though
the root cause is up to the `allocator-api2` crate to fix.
Direct use of `allocator-api2` in tests had to be replaced with the
indirection used elsewhere in the crate.
@Amanieu
Copy link
Member

Amanieu commented Jan 27, 2025

I'm not sure what's up with miri but it seems related to the allocator API. I'm away this week so I can't look into it myself.

@NeuralModder
Copy link
Author

NeuralModder commented Jan 28, 2025

@Amanieu I fixed the miri (actually a cargo test) thing, the tests were using allocator-api2 directly but there must've been some kind of commingling of the two apis when nightly was enabled, replacing the calls to allocator-api2 with calls to crate::raw fixed it.

What's failing now is tests/set.rs due to a linker warning, but only on aarch64-apple-darwin (or at least, not on linux), possibly only on nightly. My best guess is that this a platform-specific linker oddity, but of course, I have no idea why this PR would cause it. I unfortunately do not have a cross-compilation environment set up to debug this, either.

EDIT: Re-ran CI (pushed revert commit and removed it again) and it passes now, so it was probably something like a random problem with a runner and had nothing to do with the actual contents of this PR.

@Amanieu Amanieu added this pull request to the merge queue Feb 7, 2025
Merged via the queue into rust-lang:master with commit 3bcb845 Feb 7, 2025
31 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants