Embed metadata about the current page instead of parsing current path #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
|
Makes the route configuration and the code much simpler. Good idea! |
Nemo157
force-pushed
the
embed-metadata
branch
2 times, most recently
from
93e024b to
2e2d1c1
Compare
|
When working out how to test the changes I realised there's even a much simpler way to handle the menus, that let the tests verify the ajax menu even better. |
Nemo157
commented
Mar 6, 2024
|
@Nemo157 is this waiting for review again? |
GuillaumeGomez
approved these changes
Mar 20, 2024
|
@syphar Would be better to have yours. ;) |
|
Yep, it should be ready, IIRC I just fixed the two issues @GuillaumeGomez brought up. |
syphar
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
I manually tested some things around the release & platform lists and all seems to be fine.
I can't really judge the JS code, but since @GuillaumeGomez reviewed it, I'm fine.
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help out with the client-side for #2434