Simplify versions ordering in GET /api/v1/crates/{name} endpoint
#10298
+34
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the sorting of `crate.versions`. Previously, we sorted versions by semver, which is more computationally expensive compared to sorting by id/date, which can be achieved more easily directly from the database. While this change alters the sorting order, it still provides consistent output and eliminates the need for double semver sorting.
eth3lbert
force-pushed
the
tidy-crate-metadata
branch
from
622eef5 to
416534c
Compare
Turbo87
approved these changes
Jan 3, 2025
Turbo87
changed the title
versions ordering in GET /api/v1/crates/{name} endpoint
eth3lbert
commented
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the sorting of
crate.versions. Previously, we sorted versions by semver, which is more computationally expensive compared to sorting by id/date, which can be achieved more easily directly from the database. While this change alters the sorting order, it still provides consistent output and eliminates the need for double semver sorting.