cleanup: Reuse MinInt and Int from libm in compiler-builtins
#879
+168
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
changed the title
Int from libm in compiler-builtinsMinInt and Int from libm in compiler-builtins
fbstj
reviewed
Apr 21, 2025
CONTRIBUTING.md
Outdated
| - To reinterpret an integer as a float use the `f32::from_bits` constructor. The | ||
| MUSL code uses the `SET_FLOAT_WORD` macro, or a union, to do this operation. | ||
| - You may use other methods from core like `f64::is_nan`, etc. as appropriate. | ||
| - Rust does not have hex float literals. This crate provides two `hf16!`, |
There was a problem hiding this comment.
Suggested change
| - Rust does not have hex float literals. This crate provides two `hf16!`, | |
| - Rust does not have hex float literals. This crate provides four `hf16!`, |
or just drop the word
There was a problem hiding this comment.
I'm not exactly sure why this diff was part of my original PR here, but I think it doesn't apply anymore. Please feel free to send a fix for CONTRIBUTING.md though, a second set of eyes would certainly be welcome :)
Since the two crates are now in the same repo, it is easier to share code. Begin some deduplication with the integer traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the two crates are now in the same repo, it is easier to share
code. Begin some deduplication with the integer traits.