Replace the nm symbol check with a Rust implementation
#828
+264
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
symbol-check
branch
2 times, most recently
from
c98e932 to
9646d92
Compare
|
I should have the rust script invoke cargo as well; run the script with Cargo args, the script invokes Cargo and passes |
tgross35
force-pushed
the
symbol-check
branch
4 times, most recently
from
014a36d to
65d509a
Compare
|
@beetrees I think you mentioned doing something like this a long time ago - would you mind taking a look at this? |
beetrees
suggested changes
May 29, 2025
crates/symbol-check/src/main.rs
Outdated
| } | ||
| } | ||
|
|
||
| cmd.wait().expect("failed to wait on Cargo"); |
There was a problem hiding this comment.
Suggested change
| cmd.wait().expect("failed to wait on Cargo"); | |
| assert!(cmd.wait().expect("failed to wait on Cargo").success()); |
This should check the returned exit status.
These are now provided by `compiler-builtins`, so there is no need to also build the C versions. This was detected by checking for duplicate symbols and not excluding weak symbols (like CI currently does).
This should be less error-prone and adaptable than the `nm` version, and have better cross-platform support without needing LLVM `nm` installed.
Since a working `nm` is no longer needed as part of CI, the rustup component can be removed.
|
Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be less error-prone and adaptable than the
nmversion, andhave better cross-platform support without needing LLVM
nminstalled.