Add Clippy like lint groups #16464
Merged
Add Clippy like lint groups #16464
+179
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-documenting-cargo-itself
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
epage
reviewed
Jan 5, 2026
epage
reviewed
Jan 5, 2026
weihanglo
reviewed
Jan 5, 2026
Comment on lines
7
to
16
| | Group | Description | Default level | | ||
| |----------------------|------------------------------------------------------------------|---------------| | ||
| | `cargo::complexity` | code that does something simple but in a complex way | warn | | ||
| | `cargo::correctness` | code that is outright wrong or useless | deny | | ||
| | `cargo::nursery` | new lints that are still under development | allow | | ||
| | `cargo::pedantic` | lints which are rather strict or have occasional false positives | allow | | ||
| | `cargo::perf` | code that can be written to run faster | warn | | ||
| | `cargo::restriction` | lints which prevent the use of language and library features | allow | | ||
| | `cargo::style` | code that should be written in a more idiomatic way | warn | | ||
| | `cargo::suspicious` | code that is most likely wrong or useless | warn | |
Member
There was a problem hiding this comment.
- It is nice we have a similar set of groups as clippy's! Easy for users to learn.
- It might be a bit confusing since we don't have that many lints right now. And also once we stabilize one group its hard to revert back.
Anyway, this is fine when being as a nightly feature. we need to revisit when stabilization.
Member
There was a problem hiding this comment.
Note: Dynamic groups (i.e., all or warnings) aren't supported at this time
I am a bit unsure whether we want to have cargo::all. clippy::all is not a real "all" (it includes only all lints that are on by default). So sometimes the name is a bit surprising. Anyhow, this is not a blocker for this PR.
Contributor
There was a problem hiding this comment.
I agree that we should not mirror clippy::all
Muscraft
force-pushed
the
clippy-like-lint-groups
branch
from
5e8bd81 to
11324cd
Compare
This comment has been minimized.
This comment has been minimized.
Muscraft
force-pushed
the
clippy-like-lint-groups
branch
from
11324cd to
085d9d1
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
epage
approved these changes
Jan 8, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors bot
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 9, 2026
Update cargo submodule 27 commits in 94c368ad2b9db0f0da5bdd8421cea13786ce4412..8c133afcd5e0d69932fe11f5907683723f8d361d 2025-12-26 19:39:15 +0000 to 2026-01-09 03:50:15 +0000 - Isolate build script metadata progation between std and non-std crates (rust-lang/cargo#16489) - Add Clippy like lint groups (rust-lang/cargo#16464) - feat: in-memory only `Manifest` (rust-lang/cargo#16409) - Fixed incorrect version comparision during build script dependency selection (rust-lang/cargo#16486) - refactor: new type for unit index (rust-lang/cargo#16485) - feat(test): Make CARGO_BIN_EXE_ available at runtime (rust-lang/cargo#16421) - fix(package): detect dirty files when run from workspace member (rust-lang/cargo#16479) - fix(timing)!: remove `--timings=<FMT>` optional format values (rust-lang/cargo#16420) - docs(unstable): expand docs for `-Zbuild-analysis` (rust-lang/cargo#16476) - test: add `-Zunstable-options` with custom targets (rust-lang/cargo#16467) - feat(report): add cargo report rebuilds (rust-lang/cargo#16456) - feat(test-support): Use test name for dir when running tests (rust-lang/cargo#16121) - refactor: Migrate some cases to expect/reason (rust-lang/cargo#16461) - docs(build-script): clarify OUT_DIR is not cleaned between builds (rust-lang/cargo#16437) - chore: Update dependencies (rust-lang/cargo#16460) - Update handlebars to 6.4.0 (rust-lang/cargo#16457) - chore(deps): update alpine docker tag to v3.23 (rust-lang/cargo#16454) - Any build scripts can now use cargo::metadata=KEY=VALUE (rust-lang/cargo#16436) - fix(log): add `dependencies` field to `UnitRegistered` (rust-lang/cargo#16448) - Implement fine grain locking for `build-dir` (rust-lang/cargo#16155) - feat(resolver): List features when no close match (rust-lang/cargo#16445) - feat(report): new command `cargo report sessions` (rust-lang/cargo#16428) - feat (patch): Display where the patch was defined in patch-related error messages (rust-lang/cargo#16407) - test(build-rs): Reduce from 'build' to 'check' where possible (rust-lang/cargo#16444) - feat(toml): TOML 1.1 parse support (rust-lang/cargo#16415) - feat(report): support --manifest-path in `cargo report timings` (rust-lang/cargo#16441) - fix(vendor): recursively filter git files in subdirectories (rust-lang/cargo#16439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls how lint groups work within Cargo, aligning them with how Clippy handles groups1, all while simplifying the implementation (in my opinion). The first commit adds eight lint groups that mirror Clippy's groups, while the subsequent commits work towards matching how Clippy handles groups, as well as improving how lint groups work within the existing linting system.
The major changes:
Note: Dynamic groups (i.e.,
allorwarnings) aren't supported at this timeNote: There are open questions about which
Levelwe should default the groups to. This PR does not attempt to answer those questions and simply uses Clippy's default levels for convenience.Footnotes
Clippy uses groups and categories interchangeably ↩