Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate git_auth to snapbox #14172

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

dieterplex
Copy link
Contributor

Part of #14039.

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2024
@dieterplex dieterplex force-pushed the migrate-gitauth-snapbox branch 3 times, most recently from 1186059 to 5a3ad49 Compare June 30, 2024 16:42
@dieterplex dieterplex force-pushed the migrate-gitauth-snapbox branch 7 times, most recently from f030d4e to 2ff5b83 Compare July 1, 2024 06:10
{trailer}
",
trailer = if cargo_uses_gitoxide() {
format!(r#"[CREDENTIAL]s provided for "http://{addr}/foo/bar" were not accepted by the remote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a false positive redaction :)

tests/testsuite/git_auth.rs Outdated Show resolved Hide resolved
Comment on lines +441 to +422
ssh: Could not resolve hostname needs-proxy.invalid: [..] not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we shouldn't over matching against Git and SSH output, but meh we've already done that so leave it.

tests/testsuite/git_auth.rs Outdated Show resolved Hide resolved
tests/testsuite/git_auth.rs Outdated Show resolved Hide resolved
tests/testsuite/git_auth.rs Outdated Show resolved Hide resolved
@ehuss ehuss assigned weihanglo and unassigned ehuss Jul 2, 2024
@dieterplex dieterplex force-pushed the migrate-gitauth-snapbox branch 2 times, most recently from ad3d8bf to 152a0c2 Compare July 2, 2024 20:01
@dieterplex dieterplex marked this pull request as ready for review July 2, 2024 20:39
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git_auth assertion are quite hairy 😞. Anyway, thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

📌 Commit 9d91f25 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2024
@bors
Copy link
Collaborator

bors commented Jul 3, 2024

⌛ Testing commit 9d91f25 with merge f5ca9c7...

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing f5ca9c7 to master...

@bors bors merged commit f5ca9c7 into rust-lang:master Jul 3, 2024
22 checks passed
@dieterplex dieterplex deleted the migrate-gitauth-snapbox branch July 3, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants