Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:migrate doc/directory/docscrape to snapbox #14171

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

heisen-li
Copy link
Contributor

What does this PR try to resolve?

Complete the following file migration:

 tests/testsuite/directory.rs
 tests/testsuite/doc.rs
 tests/testsuite/docscrape.rs

part of #14039

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2024
tests/testsuite/doc.rs Outdated Show resolved Hide resolved
tests/testsuite/doc.rs Outdated Show resolved Hide resolved
@weihanglo
Copy link
Member

Could you reorder commits 8ac39ec? That should happen before any other commits otherwise the redaction doesn't make sense.

@heisen-li
Copy link
Contributor Author

heisen-li commented Jul 3, 2024

Could you reorder commits 8ac39ec? That should happen before any other commits otherwise the redaction doesn't make sense.

OK,thanks.opening redact it only happens in the doc.rs file, so I adjusted the order of the two commits.

@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

📌 Commit e29862c has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2024
@bors
Copy link
Collaborator

bors commented Jul 3, 2024

⌛ Testing commit e29862c with merge a0b2803...

@bors
Copy link
Collaborator

bors commented Jul 3, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a0b2803 to master...

@bors bors merged commit a0b2803 into rust-lang:master Jul 3, 2024
22 checks passed
@heisen-li heisen-li deleted the dir_doc branch July 3, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants