Skip to content

update the std::io::pipe() example to comment deadlocks #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

oconnor663
Copy link

@oconnor663 oconnor663 commented May 17, 2025

The previous version of the example wasn't a deadlock, but only because the Command object was a temporary. That's quite subtle, and I think it's better to call out the potential deadlock explicitly.

Rendered

The previous version of the example wasn't a deadlock, but only because
the Command object was a temporary. That's quite subtle, and I think
it's better to call out the potential deadlock explicitly.
@senekor
Copy link
Contributor

senekor commented May 17, 2025

I think this is too big of a change. The post has been released and there isn't anything necessarily wrong with the example. The blog is not documentation that evolves and is polished over time. Post-release updates are usually about fixing typos, broken URLs and so on.

@oconnor663 oconnor663 closed this May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants