-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
very good new binary size improvement #600
base: master
Are you sure you want to change the base?
Conversation
let me regress binary size to test this |
slightly concerned that this may not actually work unless the changeset is on master due to the jank way GHA works. |
ugh, it does! |
i can open a new PR for just the first commit to merge |
yeah I am happy to optimistically merge that change. |
e65db40
to
57eba65
Compare
57eba65
to
74a60a7
Compare
either I'm bad at regressing binary size or getting it from |
@Kobzol whoops. |
I think that we need to use |
this significantly improves binary size, we need to merge this ASAP