Add email subscription button#1538
Merged
janhohenheim merged 10 commits intosourcefrom Jul 1, 2024
Merged
Conversation
janhohenheim
changed the title
Collaborator
Author
|
Currently waiting for a reply from MailChimp because of the following lovely automated emails: I think we shouldn't be at fault here? Here's the relevant terms and conditions: |
Collaborator
Author
|
Update: I simply created a new account and now it seems fine |
Collaborator
Author
janhohenheim
requested review from
17cupsofcoffee,
AngelOnFira,
ThierryBerger,
mamaicode and
ozkriff
ThierryBerger
approved these changes
Jul 1, 2024
Collaborator
ThierryBerger
left a comment
ThierryBerger
left a comment
There was a problem hiding this comment.
you're on 🔥 ; left a few nitpicks ; to be noted I'm not too qualified to judge html/CSS so it was mostly a wording pass.
Co-authored-by: Thierry Berger <contact@thierryberger.com>
Co-authored-by: Thierry Berger <contact@thierryberger.com>
mamaicode
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24
Don't merge this yet. It's unstyled and the mailchimp campaign is not yet done.
Previews:
