Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process displayName in collection registers in array #177

Closed

Conversation

kossnikita
Copy link
Contributor

add support syntax

  _array:
    PCDTO?:
      displayName: PCDTO%s
      description: Data offset for Preempted channel %s

If displayName patch not provided, replaces index with "%s"

@kossnikita
Copy link
Contributor Author

The description processing has also been changed for cases when the array is not numbered from the zero index.

@burrbull
Copy link
Member

The description processing has also been changed for cases when the array is not numbered from the zero index.

0 was allowed because it is rare when it can be twice or more times in description.
Indices can also be chars, not only numbers.
This change can fix some cases, but break others.

@kossnikita
Copy link
Contributor Author

In this cases manual patches should be used. Patch like in my example resolve this problem

@burrbull
Copy link
Member

We need more complicated logic here.
For example take first 2 descriptions, find differences, and replace only in different parts.

@kossnikita
Copy link
Contributor Author

It's a good idea. We need introduce this not only this place, but for all name tags too. Instead this #166 for example

@burrbull
Copy link
Member

@kossnikita it's off-topic, but

There is yet one tool I'm often use:
https://github.com/burrbull/svd-yaml-compare
It is helpful in searching differences.
Just install and run
svd-compare PATH_TO_SVDDIR
It converts SVDs to yaml and cut them by peripheral.

@burrbull
Copy link
Member

closing. See #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants