Add unsafe block around DEVICE_PERIPHERALS = true in Peripherals::steal()
#947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtjd
force-pushed
the
add-unsafe-device-peripherals
branch
from
4f40dba to
3d7e14c
Compare
Make this, please. |
kurtjd
force-pushed
the
add-unsafe-device-peripherals
branch
from
3d7e14c to
e7ca4fb
Compare
Done! |
burrbull
previously approved these changes
Oct 2, 2025
|
Hm CI appears to be failing for reasons unrelated to these changes. Would you like me to make the fix as part of this PR anyway? |
|
Yes, try to fix it, please. |
kurtjd
force-pushed
the
add-unsafe-device-peripherals
branch
from
fa2e372 to
a5ecffa
Compare
Should be fixed now. Looks like this PR: rust-lang/rust#138907 merged |
burrbull
approved these changes
Oct 2, 2025
|
So svd2rust-regress completed locally for me with no errors, but during CI looks like it's failing because clippy is not installed. I'll see if I can update the workflow to ensure clippy is available during CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In edition 2024,
#[warn(unsafe_op_in_unsafe_fn)]is enabled by default.This PR adds the unsafe block around mutating
DEVICE_PERIPHERALSin the generatedPeripherals::steal()function. I had considered only adding this if the--edition=2024flag was passed, but there is no harm in this being here even for earlier editions and is IMO clearer regardless. Though if folks disagree I can make that change.