fix indexes_as_range #241
Merged
fix indexes_as_range #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Emilgardis |
Emilgardis
reviewed
Nov 12, 2023
Comment on lines
+173
to
+176
| let val = idx.parse::<u32>().ok()?; | ||
| if val.to_string() != idx { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
what exactly does this fix?
that 01 != 1?
There was a problem hiding this comment.
to note, I think it's the wrong way to fix the issue but maybe it's not
There was a problem hiding this comment.
what exactly does this fix?
that
01!=1?
Yes
There was a problem hiding this comment.
can we add a comment here to explain why we need the name to be an exact match with the integer representation
There was a problem hiding this comment.
could you add comment yourself, please? I have issues with internet, maybe several days
Emilgardis
approved these changes
Nov 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
ci stuck on waiting for runner |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-embedded/svdtools#178 (comment)