Improve node error message #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the upstream error message in the NoBitcoindInstance error to aid in debugging.
Member
|
That retry loop is horrible - it does two totally different things. We could split it up or in the first part of the loop we don't need to cache the last error, just check for > 10 and return the error after logging it. This suggestion is just from looking, I could be wrong. What ever you do I don't think the error variant should have an option in it but I'm not 100% sure without changing the code. |
Collaborator
Author
The intention of this PR was just to add more info to the error message to help debug the integration test errors we are getting, not to refactor any code. But in the meantime I have rewritten Node::with_conf to fix the whole issue, which makes this PR redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the upstream error message in the NoBitcoindInstance error to aid in debugging.