Skip to content

fix: build for macOS #249

fix: build for macOS

fix: build for macOS #249

Triggered via pull request May 10, 2024 09:04
@johanneskoesterjohanneskoester
synchronize #431
Status Success
Total duration 13s
Artifacts

conventional-prs.yml

on: pull_request_target
title-format
4s
title-format
Fit to window
Zoom out
Zoom in

Annotations

1 error and 3 warnings
mismatched types: src/bgzf/mod.rs#L260
error[E0308]: mismatched types --> src/bgzf/mod.rs:260:17 | 257 | htslib::bgzf_write( | ------------------ arguments to this function are incorrect ... 260 | buf.len() as u64, | ^^^^^^^^^^^^^^^^ expected `usize`, found `u64` | note: function defined here --> /home/runner/work/rust-htslib/rust-htslib/target/debug/build/hts-sys-54eaf746d411afb9/out/bindings.rs:10315:12 | 10315 | pub fn bgzf_write(fp: *mut BGZF, data: *const ::std::os::raw::c_void, length: usize) -> isize; | ^^^^^^^^^^ help: you can convert a `u64` to a `usize` and panic if the converted value doesn't fit | 260 | (buf.len() as u64).try_into().unwrap(), | + +++++++++++++++++++++
title-format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: amannn/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
title-format
The following actions uses node12 which is deprecated and will be forced to run on node16: amannn/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
unnecessary parentheses around function argument: src/bam/mod.rs#L1395
warning: unnecessary parentheses around function argument --> src/bam/mod.rs:1395:45 | 1395 | let rec = htslib::sam_hdr_parse((l_text + 1), text as *const c_char); | ^ ^ | = note: `#[warn(unused_parens)]` on by default help: remove these parentheses | 1395 - let rec = htslib::sam_hdr_parse((l_text + 1), text as *const c_char); 1395 + let rec = htslib::sam_hdr_parse(l_text + 1, text as *const c_char); |