Skip to content

Fix FFmpeg build

Fix FFmpeg build #713

GitHub Actions / clippy failed Mar 15, 2024 in 0s

clippy

5 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 5
Warning 0
Note 0
Help 0

Versions

  • rustc 1.76.0 (07dca489a 2024-02-04)
  • cargo 1.76.0 (c84b36747 2024-01-18)
  • clippy 0.1.76 (07dca48 2024-02-04)

Annotations

Check failure on line 63 in av_metrics/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this seems like a manual implementation of the non-exhaustive pattern

error: this seems like a manual implementation of the non-exhaustive pattern
  --> av_metrics/src/lib.rs:22:1
   |
22 |   pub enum MetricsError {
   |   ^--------------------
   |   |
   |  _help: add the attribute: `#[non_exhaustive] pub enum MetricsError`
   | |
23 | |     /// Indicates an input file could not be read for some reason.
24 | |     #[error("Could not read input file: {reason}")]
25 | |     MalformedInput {
...  |
62 | |     NonExhaustive,
63 | | }
   | |_^
   |
help: remove this variant
  --> av_metrics/src/lib.rs:62:5
   |
62 |     NonExhaustive,
   |     ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive
   = note: `-D clippy::manual-non-exhaustive` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::manual_non_exhaustive)]`

Check failure on line 227 in av_metrics/src/video/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`

error: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
   --> av_metrics/src/video/mod.rs:162:36
    |
162 |           match crossbeam::scope(|s| {
    |  ____________________________________^
163 | |             let send_result = s.spawn(move |_| {
164 | |                 let mut decoded = 0;
165 | |                 while frame_limit.map(|limit| limit > decoded).unwrap_or(true) {
...   |
226 | |             )
227 | |         }) {
    | |_________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
    = note: `-D clippy::blocks-in-conditions` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::blocks_in_conditions)]`

Check failure on line 249 in av_metrics/src/video/ssim.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `bit_depth`

error: redundant redefinition of a binding `bit_depth`
   --> av_metrics/src/video/ssim.rs:249:9
    |
249 |         let bit_depth = bit_depth;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: `bit_depth` is initially defined here
   --> av_metrics/src/video/ssim.rs:238:9
    |
238 |         bit_depth: usize,
    |         ^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals

Check failure on line 88 in av_metrics/src/video/psnr_hvs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `bit_depth`

error: redundant redefinition of a binding `bit_depth`
  --> av_metrics/src/video/psnr_hvs.rs:88:9
   |
88 |         let bit_depth = bit_depth;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
help: `bit_depth` is initially defined here
  --> av_metrics/src/video/psnr_hvs.rs:77:9
   |
77 |         bit_depth: usize,
   |         ^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals

Check failure on line 100 in av_metrics/src/video/psnr.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant redefinition of a binding `bit_depth`

error: redundant redefinition of a binding `bit_depth`
   --> av_metrics/src/video/psnr.rs:100:9
    |
100 |         let bit_depth = bit_depth;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
help: `bit_depth` is initially defined here
   --> av_metrics/src/video/psnr.rs:89:9
    |
89  |         bit_depth: usize,
    |         ^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
    = note: `#[deny(clippy::redundant_locals)]` on by default