Fix FFmpeg build #300
Closed
Fix FFmpeg build #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that clippy/rustfmt fails, but the builds (what this PR is supposed to fix) succeed. Just to prove that both PRs combined will fix CI: FreezyLemon#2 |
|
Not necessary if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error that showed up in #299.
non-exhaustive-enumsis a feature that basically allows compiling the ffmpeg crate even when the installed FFmpeg libraries are newer than the crate supports.This comes at the cost of implicitly ignoring new enum variants in the FFmpeg API, which is probably fine.
The alternative solution to this would be updating the ffmpeg crate to support the newest version (and keep it updated). Or change the CI so it only installs a fixed FFmpeg version.