01 lesson #2
Open
01 lesson #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arswarog
suggested changes
May 31, 2020
| let user = 222444555 | ||
|
|
||
| let a = timestamp.toString(16) | ||
| let b = cluster.toString(16) |
There was a problem hiding this comment.
В случае если cluster будет меньше 16 то toString(16) вернет 1 символ а не два, сколько занимает блок В, и индентификатор будет некорректным.
В таких случаях требуется сделать два символа таким образом что бы они корректно могли быть декодированны, т.е .добавить 0 в начале
| @@ -0,0 +1,21 @@ | |||
| let counter = 0 | |||
| let k = 0, p, n, m | |||
There was a problem hiding this comment.
не стоит использовать короткие имена переменных если они явно не ясны
| } | ||
| } | ||
|
|
||
| let counterSog = cleanText.length - counterGla |
There was a problem hiding this comment.
в тексте могут присутствовать не только буквы но и другие символы. они будут посчитанны как согласные. Стоит согласные тоже считать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Home work for lesson 01