Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch From AntRun to Exec-Maven #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch From AntRun to Exec-Maven #4

wants to merge 1 commit into from

Conversation

msaxena2
Copy link
Contributor

@bmmoore small changes that allow building the llvm plugin via mvn package at the top level and cleaning via mvn clean. I'd suggest rebasing and merging as it's a very small change.

bmmoore
bmmoore suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@bmmoore bmmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still call the build directory build which seems to be the convention with cmake (and note maven's target is not hidden either). Even if there is a good reason to change the name, the llvmaop/.gitignore file needs to be changed to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmmoore bmmoore bmmoore requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msaxena2 @bmmoore