Create proof trace event for tail call information #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo25
force-pushed
the
func-exit-hint
branch
3 times, most recently
from
35e6e56 to
b4c6344
Compare
function exited with a tail call
theo25
force-pushed
the
func-exit-hint
branch
from
39656e2 to
bdfceba
Compare
dwightguth
reviewed
Dec 10, 2024
lib/codegen/ProofEvent.cpp
Outdated
| @@ -372,13 +392,42 @@ std::pair<llvm::BasicBlock *, llvm::BasicBlock *> proof_event::proof_branch( | |||
| return {true_block, merge_block}; | |||
| } | |||
|
|
|||
| std::pair<llvm::BasicBlock *, llvm::BasicBlock *> proof_event::proof_branch( | |||
There was a problem hiding this comment.
this feels pretty copy-pasted; is there a way we could separate out a more generic function? maybe using templates?
include/kllvm/codegen/ProofEvent.h
Outdated
| @@ -228,6 +239,10 @@ class proof_event { | |||
| [[nodiscard]] llvm::BasicBlock *pattern_matching_failure( | |||
| kore_composite_pattern const &pattern, llvm::BasicBlock *current_block); | |||
|
|
|||
| [[nodiscard]] llvm::BasicBlock *tail_call_info( | |||
| std::string const &caller_name, bool is_tail, | |||
| llvm::Instruction *insert_before, llvm::BasicBlock *current_block); | |||
There was a problem hiding this comment.
you don't really need both insert_before and current_block, right? could we change this signature so that you pass one or the other?
…rule ordinals in function exit events
|
@dwightguth I addressed your comments. Could you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new event that provides information on the way a function exits control, specifically whether it exits via a tail call or a conventional return statement. This event is added to assist in computing the call stack of the various simplifications from the proof trace hint.