Fix some bugs relating to machine integer literals #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious, is bug 1 in the PR description the same as this issue: runtimeverification/k#4609 ? |
|
Yes. |
| std::string precision_str = str.substr(idx + 1); | ||
| long long precision = std::stoll(precision_str); | ||
| long long precision_in_bytes = (precision + 7) / 8; | ||
| char *token = (char *)malloc(precision_in_bytes); |
There was a problem hiding this comment.
Can you remind me where we handle the deallocation of this?
There was a problem hiding this comment.
It looks like this memory might be leaking currently; it's supposed to be freed by the configuration parser once it's no longer needed, but I don't see that happening currently. This is not a regression though; the same thing is already happening with other terms in the configuration parser.
There was a problem hiding this comment.
Got it. Should we add an issue in this repo so we don't lose track of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered 2 bugs relating to machine integer literals that are fixed by this PR: