Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kimp run #32

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Simplify kimp run #32

merged 6 commits into from
Nov 14, 2024

Conversation

tothtamas28
Copy link
Contributor

  • Simplify the kimp run command line interface
  • Add option --env to kimp run to pass and initial <env>
  • Replace run_program by a method run that takes a Pattern and calls llvm_interpret on it
  • Add methods parse, pattern and pretty
  • Add color output support

@tothtamas28 tothtamas28 self-assigned this Nov 13, 2024
@tothtamas28 tothtamas28 marked this pull request as ready for review November 13, 2024 16:12
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but didn't test, just read through the code).

Maybe a good idea to update the README.md?
We should keep the documentation up to date and complete, and there is also still a docker command that references geo2a (leftover from the BOB24 tutorial)

@tothtamas28
Copy link
Contributor Author

LGTM (but didn't test, just read through the code).

Here's the output of the smoke tests: https://github.com/runtimeverification/imp-semantics/actions/runs/11821219554/job/32935428888?pr=32#step:5:24

Maybe a good idea to update the README.md?

Good point. Fortunately, the command in README.md is compatible with this version (so it probably wasn't with the previous one):

kimp run examples/sumto10.imp

there is also still a docker command that references geo2a (leftover from the BOB24 tutorial)

I will take care of this in my next PR.

@tothtamas28 tothtamas28 merged commit 22ae610 into master Nov 14, 2024
3 checks passed
@tothtamas28 tothtamas28 deleted the interpret branch November 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants