modified: .github/workflows/release.yml #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: .github/workflows/test.yml - Update nix release process for test/release workflows - Publish release builds to k-framework-binar - Publish iterative CI builds to k-framework. - Reduce build times upstream and in CI PR testing. - Supporting issue of haskell-backend components being built upstream by dependents.
jberthold
approved these changes
Feb 23, 2025
| - name: Build | ||
| run: nix build .#kore-exec .#kore-rpc-booster | ||
| - name: 'Build and Cache' | ||
| uses: workflow/nix-shell-action@v3 |
There was a problem hiding this comment.
This seems to introduce an error message unrecognised flag '-c' (cannot possibly come from the commands below, and happens before any build output is printed). Is this action stable/recommended by people?
There was a problem hiding this comment.
It's the same logic / version we use in Kontrol
https://github.com/runtimeverification/kontrol/blob/master/.github/workflows/release.yml#L45
There was a problem hiding this comment.
Which looks like also produces the same error. Not sure when this was introduced though without looking at git history seems it didn't raise any flags though. I'll spend a minute on it see if there' and a similar error is thrown on linux as well.
- Undo the change to build and push to cachxi publish repo on every PR build. - This is handled lower down inherently by the cachix action for just linux.
palinatolmach
approved these changes
Feb 27, 2025
automergerpr-permission-manager
bot
deleted the
feature/publish-to-cachix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: .github/workflows/test.yml
dependents.