Skip to content

Conversation

PetarMax
Copy link
Contributor

The PR sets the default timout to a large value, which is consistent with the requirements of Kontrol engagement proofs.

@geo2a
Copy link
Contributor

geo2a commented Aug 12, 2024

Why not set this value as default at the Kontrol level?

@geo2a
Copy link
Contributor

geo2a commented Aug 12, 2024

In a Slack conversation, Petar has pointed out that the default timeout of 125 ms is unconditionally used to check the SMT prelude. That was not enough with some custom options passed to z3 via --smt-option.

We should use the user-specified timeout when checking the prelude.

@goodlyrottenapple
Copy link
Contributor

In a Slack conversation, Petar has pointed out that the default timeout of 125 ms is unconditionally used to check the SMT prelude. That was not enough with some custom options passed to z3 via --smt-option.

We should use the user-specified timeout when checking the prelude.

Will open a quick PR, as this is something I noticed last week whilst refactoring the SMT code and was going to address in a separate PR

@goodlyrottenapple
Copy link
Contributor

closing in favour of #4030

@jberthold jberthold deleted the petar/smt-timeout branch May 15, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants