Skip to content

updated CI to use GCP windows VM#176

Open
gneeri wants to merge 2 commits intomainfrom
gcp-windows-test
Open

updated CI to use GCP windows VM#176
gneeri wants to merge 2 commits intomainfrom
gcp-windows-test

Conversation

@gneeri
Copy link
Copy Markdown
Contributor

@gneeri gneeri commented Feb 27, 2026

Note

Medium Risk
CI behavior changes for Windows by targeting a different self-hosted runner label and bootstrapping Chocolatey; failures are likely if the new runner image/permissions differ or if Chocolatey install is blocked.

Overview
Updates the CI build-and-test matrix to run Windows jobs on a self-hosted runner labeled GCP.

Adds an explicit Chocolatey bootstrap step so subsequent Windows dependency installs (e.g., pkgconfiglite) work reliably on the new runner.

Written by Cursor Bugbot for commit 16a2e43. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
runmat Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 6:33pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

run: |
Set-ExecutionPolicy Bypass -Scope Process -Force
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12
iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing OS condition on Chocolatey install step

High Severity

The new "Install Chocolatey" step is missing an if: runner.os == 'Windows' condition, unlike every other OS-specific step in this workflow. This causes it to run on all three matrix runners (Linux, macOS, and Windows). The Chocolatey install script and Set-ExecutionPolicy are Windows-only, so this will fail on the Linux and macOS runners, breaking CI for those platforms.

Fix in Cursor Fix in Web

run: |
Set-ExecutionPolicy Bypass -Scope Process -Force
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12
iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chocolatey PATH not available in subsequent CI step

High Severity

The "Install Chocolatey" step installs Chocolatey (which updates the system PATH in the registry), but PATH changes within one GitHub Actions step don't propagate to subsequent steps. The next step calls choco install on line 105 but choco won't be found because the Chocolatey bin directory wasn't added via $env:GITHUB_PATH. This will break the Windows CI pipeline.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant