Skip to content

Conversation

Speshkitty
Copy link
Contributor

No description provided.

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 11, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 11, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Contributor

I know this is not a new piece of this update, but please replace Guid.GUID.newGuid() with something that isn't platform-dependent like UUID.randomUUID()

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 13, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 13, 2025
@Speshkitty
Copy link
Contributor Author

Change made as requested

@LlemonDuck
Copy link
Contributor

Use log.error("message", exception) instead of printStackTrace

Instead of CompletableFuture.runAsync -> Call#execute, you can just use Call#enqueue which is already async and uses a callback structure

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 13, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants