Skip to content

Conversation

rauvagol
Copy link

@rauvagol rauvagol commented Oct 5, 2025

Overlay that works either by itself or with the region-locker plugin to display locked chunks on the world map with any gpu.

Includes optional warnings and penalties for time spent in a locked chunk (disabled by default except for increasing (non-opaque) darkness)

First plugin, so I apologize in advance if I messed up any steps, and I will correct any issues ASAP

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 5, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 5, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@rauvagol
Copy link
Author

I suspect the plugin hub check is because of the site integration/url access potentially being used maliciously

A quick summary to explain why that exists, the user is able to input their map code, which is used to assemble a url like so

"https://chunkpicker.firebaseio.com/maps/" + mapCode + "/chunks/unlocked.json"

which returns a list of unlocked chunks.

I don't see a way this could be used maliciously, but if there are needed changes, then I will gladly make them

@riktenx
Copy link
Member

riktenx commented Oct 14, 2025

What you're doing is allowed but you MUST add a disclaimer to your manifest file stating that your plugin makes network requests and transmits your IP address to a 3rd-party server not controlled or verified by RuneLite developers.

Example: https://github.com/runelite/plugin-hub/blob/master/plugins/flipping-copilot#L4

I haven't looked at your code at all, but if there's a way for this plugin to work without doing that (like, save chunks in rsprofile or something) that's probably going to be preferred.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 14, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 14, 2025
@rauvagol
Copy link
Author

Alright, made that addition, and it does work without that, but the ability to import the chunks automatically from https://source-chunk.github.io/chunk-picker-v2/ is an optional feature that I have had very good feedback on, and the site itself is well known by people doing chunk accounts.

As for how it works/can be avoided, there are three options a user has

  • Integration with the region locker plugin: reads the list of chunks that plugin marks as unlocked (semi-self contained, convenient)
  • Manual input: lets the user input a list of allowed chunkIDs (completely self contained but a bit annoying)
  • Site reading: automatically gets your list of unlocked chunks from the sourcechunk site, will only ever make requests if you have that selected AND a map code entered, extremely convenient, but relies on third party tools.

It works the same as the chunk-tasks plugin, but instead of a checkbox to allow connection, you need to select the dropdown option

@riktenx
Copy link
Member

riktenx commented Oct 15, 2025

FYI if your networking happens behind an opt-in config, you can get rid of the manifest-level disclaimer and instead put it in @ConfigItem::warning (https://static.runelite.net/runelite-client/apidocs/net/runelite/client/config/ConfigItem.html#warning())

@rauvagol
Copy link
Author

Thanks for the info, added that warning and updated the plugin-hub pr (also made manual input the default, so ANY integrations need to be opt in)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants