-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Create lockedchunkoverlay #9210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New plugin |
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
I suspect the plugin hub check is because of the site integration/url access potentially being used maliciously A quick summary to explain why that exists, the user is able to input their map code, which is used to assemble a url like so "https://chunkpicker.firebaseio.com/maps/" + mapCode + "/chunks/unlocked.json" which returns a list of unlocked chunks. I don't see a way this could be used maliciously, but if there are needed changes, then I will gladly make them |
What you're doing is allowed but you MUST add a Example: https://github.com/runelite/plugin-hub/blob/master/plugins/flipping-copilot#L4 I haven't looked at your code at all, but if there's a way for this plugin to work without doing that (like, save chunks in rsprofile or something) that's probably going to be preferred. |
Alright, made that addition, and it does work without that, but the ability to import the chunks automatically from https://source-chunk.github.io/chunk-picker-v2/ is an optional feature that I have had very good feedback on, and the site itself is well known by people doing chunk accounts. As for how it works/can be avoided, there are three options a user has
It works the same as the chunk-tasks plugin, but instead of a checkbox to allow connection, you need to select the dropdown option |
FYI if your networking happens behind an opt-in config, you can get rid of the manifest-level disclaimer and instead put it in |
Thanks for the info, added that warning and updated the plugin-hub pr (also made manual input the default, so ANY integrations need to be opt in) |
Overlay that works either by itself or with the region-locker plugin to display locked chunks on the world map with any gpu.
Includes optional warnings and penalties for time spent in a locked chunk (disabled by default except for increasing (non-opaque) darkness)
First plugin, so I apologize in advance if I messed up any steps, and I will correct any issues ASAP