fix: Windows-specific issues related to across-threads IO operations #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Nothing that this PR touches seems to be breaking on macOS! |
This was referenced Jul 11, 2025
Member
Author
|
Tested on my Windows machine and on a different Windows machine (both Windows 11, set up from scratch) and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces several patches for Windows:
localhostinstead of0.0.0.0because Windows likes it more_to_pandasinOtelSqlEnginenow convertsrowsdirectly without converting them to a temporary CSV fileMarkdownTextAnalyzerto avoid using an intermediate temporary file to use as an input toMarkdownAnalyzer